Skip to content

Randomize Python backend shared memory region naming #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2024
Merged

Randomize Python backend shared memory region naming #351

merged 3 commits into from
Apr 8, 2024

Conversation

Tabrizian
Copy link
Member

@Tabrizian Tabrizian commented Apr 5, 2024 •
edited
Loading

I did some testing with 10 regions and everything seems to work fine.

@Tabrizian Tabrizian requested review from kthui and nnshah1 April 5, 2024 16:19
rmccorm4
rmccorm4 reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update that README section on shm region name collision and setting a prefix and such?

kthui
kthui approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@kthui kthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We could probably mark the setting prefix option on the README as deprecated, because it is no longer necessary to avoid naming collision.

@Tabrizian
Copy link
Member Author

@rmccorm4 @jackyh docs are updated.

@Tabrizian Tabrizian requested review from rmccorm4 and kthui April 5, 2024 21:23
@Tabrizian Tabrizian merged commit 4d42111 into main Apr 8, 2024
3 checks passed
@Tabrizian Tabrizian deleted the imant-shm-fix branch April 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@nnshah1 nnshah1 Awaiting requested review from nnshah1

@kthui kthui Awaiting requested review from kthui

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tabrizian @kthui @rmccorm4