Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration From Client #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration From Client #2
Changes from all commits
a1d83f8
dbbcc54
ae60daa
c5bfe42
46b8ea4
6fa74e1
66e8925
56cb033
cef7823
6506d36
02b36ca
0ea88c5
13c3c29
4a1013a
938d740
192c36b
732966e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a relic from the previous build? PA can set the protocol to be GRPC or HTTP or even just CAPI. I wonder if we can make these optional in the future, if they are not now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first started working on this my understanding from a huddle I had was that PA requires both the GRPC and HTTP client. Is this no longer the case? If so, I can cut a ticket for further build optimization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: Deferring to @matthewkotila. It's possible that PA requires both. If so, we may want to look at letting PA have HTTP, GRPC, or C-API (or any combination).