Skip to content

Update 'main' to track the 25.03 release #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update 'main' to track the 25.03 release #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01255ae
Update 'main' to track the 25.03 release
nv-kmcgill53 Feb 14, 2025
3e2d24f
updated copyright
nv-kmcgill53 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright (c) 2020-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -12,11 +12,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ARG BASE_IMAGE=nvcr.io/nvidia/tritonserver:24.12-py3
ARG TRITONSDK_BASE_IMAGE=nvcr.io/nvidia/tritonserver:24.12-py3-sdk
ARG BASE_IMAGE=nvcr.io/nvidia/tritonserver:25.01-py3
ARG TRITONSDK_BASE_IMAGE=nvcr.io/nvidia/tritonserver:25.01-py3-sdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 25.01?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand, it is 25.01?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thougth we were already at 25.02
but @mc-nv has the correct comment. This actually doesn't need to be done at all.


ARG MODEL_ANALYZER_VERSION=1.48.0dev
ARG MODEL_ANALYZER_CONTAINER_VERSION=25.01dev
ARG MODEL_ANALYZER_VERSION=1.49.0dev
ARG MODEL_ANALYZER_CONTAINER_VERSION=25.03dev
FROM ${TRITONSDK_BASE_IMAGE} as sdk

FROM $BASE_IMAGE
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As development is stopped for MA. We may not want to update version and keep last one released

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a tools team decision. @debermudez, is this PR necessary or should I close this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to make sure nothing is broken each release at this point.
So long as a pipeline has been triggered to ensure nothing is broken, we can close this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is going to be the strategy if there is a bug which needs to be patched? Will that go into a new release or will it go into a re-release of the final version of MA? This is the last issue I want resolved before I close this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nv-braf how are we handling that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've stopped active development of the tool (for now), but it is highly likely that we will have to add a new feature or implement a fix in the future, especially if the interface to PA changes.
What is prevent us from releasing a new version of MA in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing from the operations side as far as I can tell. We will manage your project how you tell us.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.48.0dev
1.49.0dev
Loading