Skip to content

Return full error when custom batcher init fails #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

Return full error when custom batcher init fails #196

merged 1 commit into from
May 2, 2023

Conversation

dyastremsky
Copy link
Contributor

@dyastremsky dyastremsky commented May 2, 2023 •
edited
Loading

  • Autoformatting
  • Returning full error (type, message) when custom batcher init fails. This was previously being lost due to the error being deleted before the string was copied.

Related server PR: triton-inference-server/server#5729

@dyastremsky dyastremsky mentioned this pull request May 2, 2023
Merged
krishung5
krishung5 approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@krishung5 krishung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

oandreeva-nv
oandreeva-nv approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dyastremsky dyastremsky merged commit 75dbd17 into main May 2, 2023
@dyastremsky dyastremsky deleted the dyas-custom-err branch May 2, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishung5 krishung5 krishung5 approved these changes

@oandreeva-nv oandreeva-nv oandreeva-nv approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyastremsky @krishung5 @oandreeva-nv