Properly remove first 4 bytes of BYTES data #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tgerdesnv
commented
Mar 26, 2024
•
tgerdesnv
commented
- Updated InferContext::GetOutput to ignore first 4 bytes of BYTES data
- Removed workarounds in GenAI-PA code that tried to remove the first 4 bytes of BYTES data
- Added datatype input to constructor for InferRequestedOutput classes
- Added Datatype() function to retrieve datatype to InferRequestedOutput classes
tgerdesnv
commented
Mar 26, 2024
nv-hwoo
approved these changes
Mar 27, 2024
mc-nv
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Add plumbing to get output datatype * ignore first 4 bytes of BYTES data for gathering output * Update py code to no longer remove leading bytes * remove workaround in tests * Fix order of args * more fixes * handle case where bytes response is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.