Skip to content

Clean up arg names #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Clean up arg names #546

merged 10 commits into from
Mar 25, 2024

Conversation

tgerdesnv
Copy link
Collaborator

@tgerdesnv tgerdesnv commented Mar 25, 2024

Rename some input stimulus args
Clean up help message
Clean up documentation

@tgerdesnv tgerdesnv marked this pull request as draft March 25, 2024 14:27
@tgerdesnv tgerdesnv marked this pull request as ready for review March 25, 2024 15:38
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, Tim! One nit, then it's good to go from my end.

* `--num-of-output-prompts`: The number of synthetic output prompts to generate
* `--input-tokens-mean`: The mean number of tokens of synthetic input data.
* `--input-tokens-stddev`: The standard deviation number of tokens of synthetic
* `--num-prompts`: The number of unique prompts to generate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could you use periods or not use periods for all of the options?

Very minor, but the consistency would be nice.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some periods

@tgerdesnv tgerdesnv merged commit c5fe0c0 into main Mar 25, 2024
3 checks passed
@tgerdesnv tgerdesnv deleted the tgerdes-update-arg-names branch March 25, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants