-
Notifications
You must be signed in to change notification settings - Fork 238
Clean up arg names #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up arg names #546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, Tim! One nit, then it's good to go from my end.
* `--num-of-output-prompts`: The number of synthetic output prompts to generate | ||
* `--input-tokens-mean`: The mean number of tokens of synthetic input data. | ||
* `--input-tokens-stddev`: The standard deviation number of tokens of synthetic | ||
* `--num-prompts`: The number of unique prompts to generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could you use periods or not use periods for all of the options?
Very minor, but the consistency would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some periods
Rename some input stimulus args
Clean up help message
Clean up documentation