Add support for COMMENT ON COLUMN in Mysql connector #25544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
requested changes
Apr 10, 2025
codeDing18
force-pushed
the
mysql-column-comment
branch
3 times, most recently
from
88f39e1 to
0595125
Compare
codeDing18
force-pushed
the
mysql-column-comment
branch
from
0595125 to
41cf90b
Compare
ebyhr
reviewed
Apr 13, 2025
| })); | ||
|
|
||
| // MySQL 8.0.13 starts to support DEFAULT value for JSON datatype | ||
| if (columnInfo.get("COLUMN_TYPE").equalsIgnoreCase("json") && !columnInfo.get("COLUMN_DEFAULT").isEmpty()) { |
There was a problem hiding this comment.
These logic are fragile - it will easily break if MySQL adds a new column attribute. I lean toward unsupporting the syntax in the connector.
There was a problem hiding this comment.
hi,I think that even if mysql adds a new column attribute,it should not change the meaning of the existing column attribute, and it is also need to determine whether the new column attribute is needed when modifying column attribute, because we do not need all column attributes in information_schema.columns when modifying column attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related to #5333
Release notes