-
Notifications
You must be signed in to change notification settings - Fork 92
Allow '@' signs in user names #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should be a bit more conform to what
|
2b525d4
to
ecf5d95
Compare
3v1n0
reviewed
Apr 5, 2025
Todo: add unit tests, add comment about |
9c139d7
to
17e2674
Compare
bjorn3
reviewed
Apr 29, 2025
bjorn3
requested changes
Apr 29, 2025
82c741f
to
918fb46
Compare
bjorn3
approved these changes
Apr 29, 2025
…stent parse errors - add a 'advance' method - add a 'begin_with_pos' method - remove the need to call 'chars()' at every call site
Co-authored-by: bjorn3 <[email protected]>
Co-authored-by: bjorn3 <[email protected]>
918fb46
to
d90ed00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #1064