Skip to content

fix(core): emulator build with PYOPT=1 #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025
Merged

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jun 3, 2025

see also #5093

@mmilata mmilata requested a review from romanz June 3, 2025 20:41
@mmilata mmilata requested a review from prusnak as a code owner June 3, 2025 20:41
@trezor-bot trezor-bot bot added this to Firmware Jun 3, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Jun 3, 2025
Copy link

github-actions bot commented Jun 3, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3W1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

Copy link
Contributor

@romanz romanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@romanz
Copy link
Contributor

romanz commented Jun 4, 2025

nit: maybe we can add a CI job to build PYOPT=1 emulator during nightly runs?

For example, something like:

diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
index a1accb4898..2f0ae06cd9 100644
--- a/.github/workflows/core.yml
+++ b/.github/workflows/core.yml
@@ -115,7 +115,7 @@ jobs:
         model: [T2T1, T3B1, T3T1, T3W1]
         coins: [universal, btconly]
         # type: [normal, debuglink]
-        type: [debuglink]
+        type: ${{ fromJSON(github.event_name == 'schedule' && '["normal", "debuglink"]' || '["debuglink"]') }}
         asan: ${{ fromJSON(needs.param.outputs.asan) }}
         exclude:
           - type: normal

@mmilata mmilata force-pushed the mmilata/module-coveragedata branch from 446bfc0 to e5a094e Compare June 4, 2025 16:46
@mmilata mmilata merged commit 11c2f31 into main Jun 5, 2025
106 checks passed
@mmilata mmilata deleted the mmilata/module-coveragedata branch June 5, 2025 13:29
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Jun 5, 2025
@romanz romanz added ci Continuous Integration (CI) related emulator only Issue which does not appear on the physical device - but on emulator only. labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration (CI) related emulator only Issue which does not appear on the physical device - but on emulator only.
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants