fix: pattern_index parameter to generic predicates is incorrect #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a generic predicate callable is used, the documented signature indicates that the third argument should be the pattern index. Unfortunately, the value that was being passed was an index into an internal array of only the queries containing predicates, not the true index of the pattern. This made it impossible for a custom directive to store information into the relevant `pattern_settings` dict (similar to how the built-in `#set!` directive does). This change fixes that by storing the pattern index into the `QueryPredicateGeneric` structure, and then plumbing that through to the predicate callable.
ObserverOfTime
approved these changes
Jul 23, 2025
ObserverOfTime
pushed a commit
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a generic predicate callable is used, the documented signature indicates that the third argument should be the pattern index. Unfortunately, the value that was being passed was an index into an internal array of only the patterns containing predicates, not the true index of the pattern. This made it impossible for a custom directive to store information into the relevant
pattern_settingsdict (similar to how the built-in#set!directive does).This change fixes that by storing the pattern index into the
QueryPredicateGenericstructure, and then plumbing that through to the predicate callable.