Skip to content

Add pyproject.toml for Custom Node Registry #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

haohaocreates
Copy link
Contributor

@haohaocreates haohaocreates commented May 23, 2024

We are building a global registry for custom nodes (similar to PyPI). The registry makes using custom nodes more reliable by reserving globally unique names for each custom node, and supporting semantic versioning.

Here’s some more information on the registry.

Action Required:

  • Go to the registry. Login and create a publisher id. Comment it here and we will update the PR (or just merge it and change it yourself).
  • Write a short the description.
  • Merge the separate Github Actions PR and run the workflow.
    If you want to publish the node manually, install the cli and run comfy node publish

Please message me on Discord if you have any questions!

@traugdor
Copy link
Owner

traugdor commented Jun 5, 2024

Can you go into more detail what this is for, why it is necessary, and how it is better than the current setup with have with the ComfyUI Manager?

@traugdor traugdor self-requested a review June 10, 2024 16:23
@traugdor
Copy link
Owner

@haohaocreates please respond:

Can you go into more detail what this is for, why it is necessary, and how it is better than the current setup with have with the ComfyUI Manager?

@haohaocreates
Copy link
Contributor Author

haohaocreates commented Jun 10, 2024 via email

Copy link
Owner

@traugdor traugdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will add PublisherID later.

@traugdor traugdor merged commit db71f19 into traugdor:main Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants