fix(Traefik Hub): 🐛 handle main and latest build #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
reviewed
Jan 31, 2025
mloiseleur
reviewed
Jan 31, 2025
There was a problem hiding this comment.
@darkweaver87 There is another use case to cover, see my suggestion on test.
darkweaver87
force-pushed
the
fix/hub-version
branch
from
51373ec to
883dc50
Compare
mloiseleur
approved these changes
Feb 6, 2025
mloiseleur
changed the title
Co-authored-by: Michel Loiseleur <[email protected]>
traefiker
force-pushed
the
fix/hub-version
branch
from
883dc50 to
e8abe1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug introduced in last release where we added requirements on hub version.
Motivation
Checking hub version can fail in some CI checks during Hub release process.
More
make testand all the tests passed