-
Notifications
You must be signed in to change notification settings - Fork 775
Add extraObjects
value that allows creating supportive / adhoc resources
#595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @colearendt Thanks for your interest in Traefik ! We will think about it. In the mean time, as you noticed, you can include this chart as a sub-chart of your own. We plan to merge #373 soon, in order to help. |
That's definitely a possible workaround. However, it is a noteworthy amount of tedious work tracking upstream versions of the traefik chart, all to add something that could (IMO should) be considered "baseline functionality." How many such charts w/ traefik as a sub-chart will be created by the community because some CRD is needed to set up a baseline functional traefik instance w/ appropriate middlewares / etc.? Trusting the For instance, traefik v1 allowed creating middlewares via annotations. v2 has moved to using CRDs: https://community.traefik.io/t/global-middleware-with-kubernetes-crd/9908/2?u=_cole In practice, this means that the
It's also worth noting that my experience with sub-charts is less than ideal. Lots of complexities can be introduced by the namespacing that it creates. It may be fine in this case, but it's certainly not my favorite thing in the world to do 😄 |
@colearendt It's been accepted and it's now available. See #643. |
Welcome!
What did you expect to see?
There is a pattern I have recently been made aware of in helm charts to create an
extraObjects
value, evaluated as a template (similar to discussion on #588 ), which allows deploying supporting kubernetes resources along with the traefik deployment.In many cases, it can avoid the need for additional (fake helm chart w/ a few resources), extended (chart that extends the traefik chart), or adhoc deployments (
kubectl apply
and friends).We discussed before adding to our helm charts here: rstudio/helm#115
I'm not sure if Bitnami deserves the original credit, but they call their value
extraDeploy
. We thoughtextraObjects
was a better name in our context 🤷In any case, I would be happy to write a PR with the functionality if it seems like a welcome addition. In particular, we would use it immediately for:
IngressRoutes
that are related to thetraefik
service (i.e. exposing the dashboard, etc.)Middlewares
that are used commonly by lots of our services (and thus are more appropriately scoped to traefik)Our implementation:
https://github.com/rstudio/helm/blob/ac2ad2b2e3c84309a456f6229934e5170c82164e/charts/rstudio-library/templates/_tplvalues.tpl#L6-L14
https://github.com/rstudio/helm/blob/ac2ad2b2e3c84309a456f6229934e5170c82164e/charts/rstudio-connect/templates/extra-objects.yaml#L1-L4
The text was updated successfully, but these errors were encountered: