Skip to content

Add extraObjects value that allows creating supportive / adhoc resources #595

Closed
@colearendt

Description

@colearendt

Welcome!

  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?

There is a pattern I have recently been made aware of in helm charts to create an extraObjects value, evaluated as a template (similar to discussion on #588 ), which allows deploying supporting kubernetes resources along with the traefik deployment.

In many cases, it can avoid the need for additional (fake helm chart w/ a few resources), extended (chart that extends the traefik chart), or adhoc deployments (kubectl apply and friends).

We discussed before adding to our helm charts here: rstudio/helm#115

I'm not sure if Bitnami deserves the original credit, but they call their value extraDeploy. We thought extraObjects was a better name in our context 🤷

In any case, I would be happy to write a PR with the functionality if it seems like a welcome addition. In particular, we would use it immediately for:

  • a couple of IngressRoutes that are related to the traefik service (i.e. exposing the dashboard, etc.)
  • a couple of Middlewares that are used commonly by lots of our services (and thus are more appropriately scoped to traefik)

Our implementation:
https://github.com/rstudio/helm/blob/ac2ad2b2e3c84309a456f6229934e5170c82164e/charts/rstudio-library/templates/_tplvalues.tpl#L6-L14

https://github.com/rstudio/helm/blob/ac2ad2b2e3c84309a456f6229934e5170c82164e/charts/rstudio-connect/templates/extra-objects.yaml#L1-L4

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/proposala proposal that needs to be discussed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions