Skip to content

Adjust parsing of flags when the output is a generic map[string]string #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2025
Merged

Adjust parsing of flags when the output is a generic map[string]string #63

merged 3 commits into from
Feb 13, 2025

Conversation

bruno-de-queiroz
Copy link
Contributor

@bruno-de-queiroz bruno-de-queiroz commented Feb 5, 2025 •
edited
Loading

What does this PR do?

With the current parsing is not possible to set values to a field map[string]string in which the key contains ..

Motivation

For example: using the flags --tracing.resourceAttributes.service.environment=test, currently the value is mapped like service= instead of service.environment=test.

More

  • Added test cases

@bruno-de-queiroz bruno-de-queiroz mentioned this pull request Feb 5, 2025
Merged
1 task
rtribotte
rtribotte reviewed Feb 6, 2025
View reviewed changes
rtribotte
rtribotte reviewed Feb 6, 2025
View reviewed changes
@rtribotte rtribotte added the kind/bug/fix a bug fix label Feb 6, 2025
@bruno-de-queiroz
Copy link
Contributor Author

Hi folks, any news about this?

@bruno-de-queiroz
Copy link
Contributor Author

bump

rtribotte
rtribotte approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevinpollet kevinpollet changed the title fix: adjusting parsing of flags when the output is a generic map[string]string and the key contains '.' Adjust parsing of flags when the output is a generic map[string]string Feb 13, 2025
kevinpollet
kevinpollet approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit 7e1b633 into traefik:master Feb 13, 2025
4 checks passed
@kevinpollet kevinpollet mentioned this pull request Feb 13, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
kind/bug/fix a bug fix kind/enhancement a new or improved feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bruno-de-queiroz @kevinpollet @rtribotte @traefiker