-
Notifications
You must be signed in to change notification settings - Fork 109
DOC Prepare for docs site #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Prepare for docs site #981
Conversation
c6e10fb
to
e7e4b97
Compare
@@ -67,7 +68,8 @@ | |||
"allow-plugins": { | |||
"composer/installers": true, | |||
"silverstripe/recipe-plugin": true, | |||
"silverstripe/vendor-plugin": true | |||
"silverstripe/vendor-plugin": true, | |||
"dealerdirect/phpcodesniffer-composer-installer": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required for composer to install correctly in CI with the new silverstripe/documentation-lint being added
30cd87f
to
9c802fe
Compare
Looks good to me. Nice work. |
I remember the whole "numbering prefix" issue. I guess you're still using the same documentation generator? :P |
Probably 😅 It's https://github.com/silverstripe/doc.silverstripe.org/ which uses gatsby. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to catch all the **NOTE**
and **IMPORTANT**
style blocks that need to be turned into callout blocks, but I may have missed some. Can you please have a quick search for any I missed?
I probably also missed some code blocks that are missing use
statements
cd5c9d7
to
72a8115
Compare
79bbba6
to
31c1584
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#981 (comment) still hasn't been responded to
31c1584
to
c25a010
Compare
Have moved _manifest_exclude from docs/en to docs where it was originally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue silverstripe/.github#420
This PR is preparation for adding Fluent to the "Optional Features" section on docs.silverstripe.org
This PR:
-
for bullet points rather than*
This PR will be used on the CMS 5 version of docs.silverstripe.org, and will be merged up to also be used on the CMS 6 version