Remove unused broken clone function #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base class doesn't have a clone member function, so the code was never valid. As it was unused, that didn't cause problems until clang caught this earlier than instantiation in llvm/llvm-project#84050
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 30, 2024
…-system-reviewers,sergesanspaille,nalexander The base class doesn't have a clone member function, so the code was never valid. As it was unused, that didn't cause problems until clang caught this earlier than instantiation in llvm/llvm-project#84050 Submitted upstream as tpoechtrager/cctools-port#148 Differential Revision: https://phabricator.services.mozilla.com/D208688
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 1, 2024
…-system-reviewers,sergesanspaille,nalexander The base class doesn't have a clone member function, so the code was never valid. As it was unused, that didn't cause problems until clang caught this earlier than instantiation in llvm/llvm-project#84050 Submitted upstream as tpoechtrager/cctools-port#148 Differential Revision: https://phabricator.services.mozilla.com/D208688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base class doesn't have a clone member function, so the code was never valid. As it was unused, that didn't cause problems until clang caught this earlier than instantiation in
llvm/llvm-project#84050