Modify tests to ensure $PYTHONPATH is given to the custom interpreter #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
requested changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should finally resolve #343.
Before 2.17.0, we weren't honoring
$PYTHONPATHwhen it was passed to the custom interpreter (but were honoring it when not using a custom interpreter).With the changes made in 2.17.0, we (unexpectedly) began to honor
$PYTHONPATHwhen using--python. I believe this is fine since as I explained above we honored it when it was used without this option and because of this it makes sense to pass this env var to the custom interpreter child process instead of ignoring it. Maybe we should document this in the 2.17.0 release notes?This adds a test and changes another to ensure that there aren't future hiccups when using this env var.