#47 popover bug fixes #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent." instead of being blank if the notes field is empty.
meganrm
approved these changes
Feb 19, 2017
There was a problem hiding this comment.
Hey, these are great fixes... playing around with this I realized one more think I overlooked, which is the map popovers should close when you go back home. Maybe stay open when the user searches? Like they've clicked on an event they were interested in before they searched. Not critical
| <tr id="{{rowid}}" class= 'event-row' data-Main_State-filter={{State}} data-Member-filter={{Member}} | ||
| data-container="body" data-animation="true" data-html="true" data-toggle="popover" data-placement="top" | ||
| title="Notes <a href='javascript:void(0)' class='close'>×</a>" | ||
| data-content="{{#if Notes}}{{Notes}}{{/if}}{{#unless Notes}}There are no notes for this event.{{/unless}}"> |
| @@ -427,6 +425,7 @@ | |||
| }); | |||
| marker.setIcon('https://maps.google.com/mapfiles/ms/icons/red-dot.png'); | |||
| marker.addListener('click', function() { | |||
| infowindow.setContent(contentString); | |||
There was a problem hiding this comment.
Can you also have these close when the user searches and when they got back to home
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #47.
I wound up going with close buttons for the popover instead of the original idea of clicking off the table closing them. That's how the ones on the google map popover are implemented and I figure it's worth keeping things in sync.