fix(@toss/hangul): replace non-null assertion(!) with nullish coalescing operator (??)

[saul-atomrigs]

Overview

slash/packages/common/hangul/src/disassembleCompleteHangulCharacter.ts

Lines 30 to 32 in 60b035b

	first: HANGUL_CHARACTERS_BY_FIRST_INDEX[firstIndex]!,
	middle: HANGUL_CHARACTERS_BY_MIDDLE_INDEX[middleIndex]!,
	last: HANGUL_CHARACTERS_BY_LAST_INDEX[lastIndex]!,

This PR addresses the typescript-eslint warning (forbidden non-null assertion) by replacing it with the nullish coalescing operator (??) and giving an empty string as the default value.

AS-IS

TO-BE

source: https://typescript-eslint.io/rules/no-non-null-assertion/

PR Checklist

• [✅] I read and included theses actions below

1. I have read the Contributing Guide
2. I have written documents and tests, if needed.

[vercel]

@saul-atomrigs is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

[raon0211]

Thanks for your contribution!

Actually this was intended on purpose; there is no chance that the array access results in returning undefined. Adding nullish coalescing will add extra runtime overhead and increase in bundle size.

If possible, I think adding some comments like // eslint-disable-next-line is a better design choice.

[saul-atomrigs]

Oh, I see your point makes sense. Thanks!

Would you like me to add either // eslint-disable-next-line above each line or maybe /* eslint-disable @typescript-eslint/no-non-null-assertion */ for the entire page? Happy to contribute :)

[raon0211]

I think adding separate // eslint-disable-next-line @typescript-eslint/no-non-null-assertion for each line would be helpful for us :)

[saul-atomrigs]

Changes applied. Many thanks!

[raon0211]

Thanks!