fix(@toss/react): useOutsideClickEffect is called twice on touch event #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #354 and #449
I agree with this answer.
click
event works fine on touchable screen too, so there is no need to have atouch
event listener.I believe another solution might be adding
e.preventDefault()
for thetouch
event. According to MDN:However, I think this is a bit more over-engineering... so I decided to go with the first solution.
PR Checklist