fix(error-boundary): remove ErrorBoundaryGroup's not on purpose reset because of isMounted's side effect

[manudeli]

related with toss/suspensive#92

Remove ErrorBoundaryGroup's not on purpose reset because of isMounted's side effect

useIsMounted of @toss/react is implemented by useState, but we don't need to use useIsMounted triggering rerender component self when after mount.

useIsMounted of @toss/react

import { useEffect, useState } from 'react';

/** @tossdocs-ignore */
export function useIsMounted() {
  const [mounted, setMounted] = useState(false);
  useEffect(() => {
    setMounted(true);
  }, []);
  return mounted;
}

before this Pull Request, ErrorBoundaryGroup used useIsMounted to prevent reseting ErrorBoundaryGroup self on first rendering, and after mounting and checked whether parent ErrorBoundaryGroup.resetKey is changed to reset self.

but after this Pull Request is merging, we don't need to make unnecessary rerendering due to useIsMounted.

In addition, we can prevent unintended ErrorBoundaryGroup resetting by useIsMounted.

When first I add this ErrorBoundaryGroup in @toss/error-boundary, I couldn't consider useIsMounted's rerendering side effect

AS-IS

ErrorBoundaryGroup will trigger reset on render because of useIsMounted

TO-BE

ErrorBoundaryGroup won't trigger reset on render because of removed useIsMounted

Check more detail and procedure to add this Pull Request in toss/suspensive#92 please

PR Checklist

• I read and included theses actions below

1. I have read the Contributing Guide
2. I have written documents and tests, if needed.

[netlify]

👷 Deploy request for slash-libraries pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	a649ad0

[manudeli]

I thought this BaseErrorBoundary.updatedWithError is unnecessary field, there is no updatedWithError in https://github.com/bvaughn/react-error-boundary/blob/master/src/ErrorBoundary.ts too.

If this is matter, let me know why meaningful please.

[manudeli]

I remove this method BaseErrorBoundary.resetState. if no updatedWithError field, resetState is not anymore meaningful too.
I thought this.setState(initialState) is better to express what this is.

[manudeli]

I made custom hook, useIsChanged to check whether value is changed with previous rendering value.

this hook will check parent ErrorBoundaryGroup.resetKey is changed
If parentErrorBoundaryGroup.resetKey is changed, ErrorBoundaryGroup self will change resetkey to propagate to child ErrorBoundaryGroup recursively.

[okinawaa]

LGTM👍🚀

[vercel]

@manudeli is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.