feat(@toss/storage): Gave scalability to two methods of NumberTypedStorage. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for slash-libraries pending review.Visit the deploys page to approve it
|
hoseungme
reviewed
Feb 1, 2023
packages/common/storage/src/typed/storages/NumberTypedStorage.ts
Outdated
Show resolved
Hide resolved
hoseungme
reviewed
Feb 2, 2023
| @@ -2,13 +2,13 @@ | |||
| import { TypedStorage } from './TypedStorage'; | |||
|
|
|||
| export class NumberTypedStorage extends TypedStorage<number> { | |||
| public increase(): void { | |||
| public increase(offset = 1): void { | |||
There was a problem hiding this comment.
Please specify the type of offset.
public increase(offset: number = 1): void;There was a problem hiding this comment.
It's good that it's explicit! but it is ok to ignore line warning?
hoseungme
reviewed
Feb 2, 2023
| const typed = new NumberTypedStorage('increase-test', { initialValue: 10 }); | ||
| describe('NumberTypedStorage', () => { | ||
| describe('increase() method', () => { | ||
| it('should increase the value of the given key by 1. when given no argument', () => { |
There was a problem hiding this comment.
describe('when there is no given offset', () => {
it('should increase the value of the given key by 1', () => {
...
});
});| typed.increase(); | ||
| expect(typed.get()).toBe(11); | ||
| }); | ||
| it('should increase the value of the given key by argument.', () => { |
There was a problem hiding this comment.
describe('when there is given offset', () => {
it('should increase the value of the given key by offset', () => {
...
});
});| it('주어진 key의 값을 1 감소시킨다.', () => { | ||
| const typed = new NumberTypedStorage('decrease-test', { initialValue: 10 }); | ||
| describe('decrease() method', () => { | ||
| it('should decrease the value of the given key by 1. when given no argument', () => { |
There was a problem hiding this comment.
describe('when there is no given offset', () => {
it('should decrease the value of the given key by 1', () => {
...
});
});| typed.decrease(); | ||
| expect(typed.get()).toBe(9); | ||
| }); | ||
| it('should decrease the value of the given key by argument.', () => { |
There was a problem hiding this comment.
describe('when there is given offset', () => {
it('should decrease the value of the given key by offset', () => {
...
});
});…k-Tech/slash into feat-storage-number
|
@hoseungjang thank you for your sophisticated translation😁 |
hoseungme
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Building an application, you might want to increase and decrease the number as much as you want, instead of adjusting the number one by one.
In that case, two methods(increase, decrease) were modified to receive argument.
PR Checklist