feat(error-boundary): add withErrorBoundary for consistency, and add displayName in development mode #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for slash-libraries pending review.Visit the deploys page to approve it
|
manudeli
changed the title
manudeli
commented
Jan 24, 2023
Comment on lines
+15
to
+18
| if (process.env.NODE_ENV !== 'production') { | ||
| const name = Component.displayName || Component.name || 'Component'; | ||
| Wrapped.displayName = `withAsyncBoundary(${name})`; | ||
| } |
There was a problem hiding this comment.
- add withAsyncBoundary's displayName for development mode
Comment on lines
+5
to
+21
| export default function withErrorBoundary<Props extends Record<string, unknown> = Record<string, never>>( | ||
| Component: ComponentType<Props>, | ||
| errorBoundaryProps: ComponentProps<typeof ErrorBoundary> | ||
| ) { | ||
| const Wrapped = (props: Props) => ( | ||
| <ErrorBoundary {...errorBoundaryProps}> | ||
| <Component {...props} /> | ||
| </ErrorBoundary> | ||
| ); | ||
|
|
||
| if (process.env.NODE_ENV !== 'production') { | ||
| const name = Component.displayName || Component.name || 'Component'; | ||
| Wrapped.displayName = `withErrorBoundary(${name})`; | ||
| } | ||
|
|
||
| return Wrapped; | ||
| } |
There was a problem hiding this comment.
- add withErrorBoundary like withAsyncBoundary of @toss/async-boundary
raon0211
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(error-boundary): add withErrorBoundary for consistency
Why add displayName in this Pull Request
🔗 Convention: Wrap the Display Name for Easy Debugging in react-docs
PR Checklist