Skip to content

feat(error-boundary): add withErrorBoundaryGroup's feature to pass errorBoundaryGroupProps #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Jan 4, 2023

Add withErrorBoundaryGroup's feature to pass errorBoundaryGroupProps

When I made withErrorBoundaryGroup, I missed adding a feature of withErrorBoundaryGroup's passing props to inner ErrorBoundaryGroup. so I made this Pull Request to add it.

Example

const ErrorBoundaryGrouped = withErrorBoundaryGroup<{ something: string }>(({
  something
}) => {
  return <></>
}, {
  blockOutside: true, // Use errorBoundaryGroupProps, also It's optional
})

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for slash-libraries ready!

Name Link
🔨 Latest commit 8df3922
🔍 Latest deploy log https://app.netlify.com/sites/slash-libraries/deploys/63bb698735234d00084f861e
😎 Deploy Preview https://deploy-preview-182--slash-libraries.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@raon0211 raon0211 enabled auto-merge (squash) January 9, 2023 01:10
@raon0211 raon0211 merged commit fae2988 into toss:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants