Fix negative speed issue #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the negative speed issue by adjusting vehicle positions before updating their speeds and includes preliminary DTAsolver updates. It also updates the simulation notebook execution counts and reported simulation metrics.
- Updated vehicle position logic in uxsims.py to ensure positions and boundaries are enforced.
- Revised execution counts and simulation output metrics in the demo notebook to reflect the latest simulation results.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| uxsim/uxsim.py | Adjustments in vehicle position and speed update logic |
| demos_and_examples/demo_notebook_01en.ipynb | Updated execution counts and simulation metric outputs |
Comments suppressed due to low confidence (1)
uxsim/uxsim.py:322
- The update to veh.v may still allow negative speeds if veh.x is negative. Consider enforcing non-negative speeds by applying a max(veh.v, 0) after the update or ensuring veh.x cannot be negative.
veh.v += veh.x/s.W.DELTAT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #203
This PR also includes DTAsolver updates. However, they are still work in progress