Update setup.py to check if WITH_CUDA is set #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if environment variable is set before retrieving variable at setup time.
|
Ah right, of course. I was so focused on making conda-forge work correctly. Thanks for the contribution! |
stefdoerr
approved these changes
Feb 14, 2025
|
I should really not review code before my first morning coffee. There were two logic errors in this PR (the first |
|
Haha looks like I shouldn't submit a PR before I've had my first coffee either! Thanks for the fix and quick turn around. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.environ.get("WITH_CUDA", "0") == "0"returnTrueeven if the environment variable is not set. Thus currently, the default behavior is to automatically fall back to CPU-only build ifWITH_CUDAis not set.This introduces a small change to the first check if the
WITH_CUDAis set. If not set, it falls back to the build defined bytorch.cuda._is_compiled().