Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures consistency when using the HDF5 dataset class. Specifically, when
self.cached=True
, the_preload_data(self)
function correctly handles cases where the embed 1D array is shared across all samples. Whenself.cached=False
, the dataset instead processes tensors directly, assuming:However, this assumption caused errors when embed was shared across samples, as it incorrectly indexed node
i
within the 1D embed array.This PR fixes the issue and includes a pytest to verify consistency with and without caching.