Drop channels support #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
force-pushed
the
chore/drop-channels
branch
from
d832f87 to
3847ba8
Compare
|
LGTM! |
dopry
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
LGTM! Neither you nor I are testing this. There is enough volatility around asgi and channels at the moment to make maintaining it beyond our current capabilities in terms of our availability. The vast majority of cms driven sites really just need an API for headless.
I'm good with dropping this.
zerolab
force-pushed
the
chore/drop-channels
branch
from
3847ba8 to
f393228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #334
Fixes #317