Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unittests to work with aiohttp 3.10+ #326

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

tomplus
Copy link
Owner

@tomplus tomplus commented Jul 31, 2024

This PR adjusts unitests to work with aiohttp 3.10+ where http sessions have to be created within an async function.
Ref: aio-libs/aiohttp#8555

@tomplus tomplus changed the title fix unittests to work with aiohttp 3.10+111 fix unittests to work with aiohttp 3.10 Jul 31, 2024
@tomplus tomplus changed the title fix unittests to work with aiohttp 3.10 fix unittests to work with aiohttp 3.10+ Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 3.93701% with 122 lines in your changes missing coverage. Please review.

Project coverage is 28.11%. Comparing base (f53d443) to head (154c772).

Files Patch % Lines
...tes_asyncio/test/test_admissionregistration_api.py 0.00% 2 Missing ⚠️
..._asyncio/test/test_admissionregistration_v1_api.py 0.00% 2 Missing ⚠️
...io/test/test_admissionregistration_v1alpha1_api.py 0.00% 2 Missing ⚠️
...cio/test/test_admissionregistration_v1beta1_api.py 0.00% 2 Missing ⚠️
kubernetes_asyncio/test/test_apiextensions_api.py 0.00% 2 Missing ⚠️
...bernetes_asyncio/test/test_apiextensions_v1_api.py 0.00% 2 Missing ⚠️
...ubernetes_asyncio/test/test_apiregistration_api.py 0.00% 2 Missing ⚠️
...rnetes_asyncio/test/test_apiregistration_v1_api.py 0.00% 2 Missing ⚠️
kubernetes_asyncio/test/test_apis_api.py 0.00% 2 Missing ⚠️
kubernetes_asyncio/test/test_apps_api.py 0.00% 2 Missing ⚠️
... and 51 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   28.11%   28.11%           
=======================================
  Files         779      779           
  Lines       92138    92138           
=======================================
  Hits        25904    25904           
  Misses      66234    66234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomplus tomplus merged commit 950ceac into master Jul 31, 2024
13 of 14 checks passed
tomplus added a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant