Add Dynamic Client support #260

bobh66 · 2023-06-03T18:16:09Z

Ported the DynamicClient from the synchronous kubernetes client and converted to async. Included docs and examples.

Fixes #209

…_asyncio into dynamic_client

Signed-off-by: Bob Haddleton <[email protected]>

- remove delete_user_pvc, now handled by kubespawner - increase user cull timeout to a month - temporarily disable monitor until tomplus/kubernetes_asyncio#260

tomplus

Impressive! Thanks for you contribution.

kubernetes_asyncio/dynamic/discovery.py

kubernetes_asyncio/test/test_discovery.py

kubernetes_asyncio/client/rest.py

Signed-off-by: Bob Haddleton <[email protected]>

…_asyncio into dynamic_client

Signed-off-by: Bob Haddleton <[email protected]>

bobh66 · 2023-06-29T01:11:19Z

kubernetes_asyncio/dynamic/client.py

+
+        # Use field selector to query for named instance so the watch parameter is handled properly.
+        if name:
+            field_selector = f"metadata.name={name}"


I also pulled in the changes from this PR - kubernetes-client/python#2076 - to fix an issue with watching resources by name with the dynamic client.

tomplus · 2023-07-01T22:00:30Z

Looks good to me.

There is a minor issue in e2e tests, could you fix it? Thanks.

Signed-off-by: Bob Haddleton <[email protected]>

tomplus · 2023-07-02T07:22:15Z

Sorry for bothering you again, now flak8 complains...

Signed-off-by: Bob Haddleton <[email protected]>

bobh66 · 2023-07-02T13:43:23Z

Sorry for bothering you again, now flak8 complains...

Sorry, I should have caught those. Hopefully all is good now.

Signed-off-by: Bob Haddleton <[email protected]>

codecov · 2023-07-02T14:03:27Z

Codecov Report

Patch coverage: 22.51% and project coverage change: -0.01 ⚠️

Comparison is base (04f1d0f) 24.67% compared to head (d5e0869) 24.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   24.67%   24.66%   -0.01%     
==========================================
  Files         728      736       +8     
  Lines       97998    99024    +1026     
==========================================
+ Hits        24178    24429     +251     
- Misses      73820    74595     +775

Impacted Files	Coverage Δ
kubernetes_asyncio/e2e_test/test_dynamic_client.py	`0.00% <0.00%> (ø)`
kubernetes_asyncio/dynamic/client_test.py	`13.79% <13.79%> (ø)`
kubernetes_asyncio/dynamic/client.py	`22.22% <22.22%> (ø)`
kubernetes_asyncio/dynamic/discovery.py	`22.56% <22.56%> (ø)`
kubernetes_asyncio/dynamic/resource.py	`25.64% <25.64%> (ø)`
kubernetes_asyncio/dynamic/discovery_test.py	`35.48% <35.48%> (ø)`
kubernetes_asyncio/dynamic/exceptions.py	`51.06% <51.06%> (ø)`
kubernetes_asyncio/dynamic/__init__.py	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

tomplus

Thanks for your contribution.

Jean-Daniel · 2023-08-01T08:45:38Z

Just a nitpick, but I think this commit misses a require change in setup.py.
As it adds a new package, it should be append in the setup.py package list.
the dynamic package it currently ignored by deployment tools like pip.

tomplus · 2023-08-01T16:46:38Z

@Jean-Daniel You are right, thanks! Do you want to submit PR for it?

bobh66 · 2023-08-01T17:23:16Z

Should it also be added to kubernetes_asyncio/__init__.py?

https://github.com/tomplus/kubernetes_asyncio/blob/master/kubernetes_asyncio/__init__.py

tomplus · 2023-08-02T08:31:22Z

@bobh66 yes, it'd be beneficial.

Jean-Daniel · 2023-08-03T13:19:43Z

@Jean-Daniel You are right, thanks! Do you want to submit PR for it?

PR submitted: #266

bobh66 · 2023-08-16T18:43:27Z

Hi @tomplus - any chance we could get a release with these changes? Happy to help if there is anything I can do. Thanks!

tomplus · 2023-08-17T13:42:38Z

Sorry for the inconvenience, I'm going to release it over the weekend.

tomplus · 2023-08-21T20:27:48Z

It's been just released, v25.11.0.

bobh66 added 8 commits May 3, 2023 13:54

Add dynamic client support

66fe9d4

Add dynamic client support

3b63677

Merge branch 'dynamic_client' of https://github.com/bobh66/kubernetes…

f71ba0a

…_asyncio into dynamic_client

refactor(dynamic): use await magic method

59cb228

Add docs readme info for DynamicClient

2e8e319

Signed-off-by: Bob Haddleton <[email protected]>

Fix example

71c2765

Signed-off-by: Bob Haddleton <[email protected]>

Fix examples

b4bd512

Signed-off-by: Bob Haddleton <[email protected]>

Remove requirements entry and fix example

16fc63d

Signed-off-by: Bob Haddleton <[email protected]>

tomplus requested changes Jun 16, 2023

View reviewed changes

kubernetes_asyncio/dynamic/discovery.py Show resolved Hide resolved

kubernetes_asyncio/test/test_discovery.py Outdated Show resolved Hide resolved

kubernetes_asyncio/client/rest.py Outdated Show resolved Hide resolved

kubernetes_asyncio/client/rest.py Outdated Show resolved Hide resolved

bobh66 added 5 commits June 18, 2023 09:55

[docs] add readme info for DynamicClient

acc8bdd

Signed-off-by: Bob Haddleton <[email protected]>

[fix] cleanup examples

5ce2799

Signed-off-by: Bob Haddleton <[email protected]>

[refactor] review feedback changes

93bbfc0

Signed-off-by: Bob Haddleton <[email protected]>

Merge branch 'dynamic_client' of https://github.com/bobh66/kubernetes…

802b830

…_asyncio into dynamic_client

[refactor] remove changes from client/rest.py

6c070e2

Signed-off-by: Bob Haddleton <[email protected]>

bobh66 commented Jun 29, 2023

View reviewed changes

[test] Fix e2e test case

8cf5910

Signed-off-by: Bob Haddleton <[email protected]>

[lint] Fix flake8 errors

774e6c5

Signed-off-by: Bob Haddleton <[email protected]>

[lint] Fix isort errors

d5e0869

Signed-off-by: Bob Haddleton <[email protected]>

tomplus approved these changes Jul 2, 2023

View reviewed changes

tomplus merged commit 4695715 into tomplus:master Jul 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Dynamic Client support #260

Add Dynamic Client support #260

bobh66 commented Jun 3, 2023 •

edited

Loading

tomplus left a comment

bobh66 Jun 29, 2023

tomplus commented Jul 1, 2023

tomplus commented Jul 2, 2023

bobh66 commented Jul 2, 2023

codecov bot commented Jul 2, 2023

tomplus left a comment

Jean-Daniel commented Aug 1, 2023

tomplus commented Aug 1, 2023

bobh66 commented Aug 1, 2023 •

edited

Loading

tomplus commented Aug 2, 2023

Jean-Daniel commented Aug 3, 2023

bobh66 commented Aug 16, 2023

tomplus commented Aug 17, 2023

tomplus commented Aug 21, 2023

Add Dynamic Client support #260

Add Dynamic Client support #260

Conversation

bobh66 commented Jun 3, 2023 • edited Loading

tomplus left a comment

Choose a reason for hiding this comment

bobh66 Jun 29, 2023

Choose a reason for hiding this comment

tomplus commented Jul 1, 2023

tomplus commented Jul 2, 2023

bobh66 commented Jul 2, 2023

codecov bot commented Jul 2, 2023

Codecov Report

tomplus left a comment

Choose a reason for hiding this comment

Jean-Daniel commented Aug 1, 2023

tomplus commented Aug 1, 2023

bobh66 commented Aug 1, 2023 • edited Loading

tomplus commented Aug 2, 2023

Jean-Daniel commented Aug 3, 2023

bobh66 commented Aug 16, 2023

tomplus commented Aug 17, 2023

tomplus commented Aug 21, 2023

bobh66 commented Jun 3, 2023 •

edited

Loading

bobh66 commented Aug 1, 2023 •

edited

Loading