Skip to content

Add package for rmstylusbutton #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

MoritzBoehme
Copy link

I am adding the package RMStylusButton.
It's a fork of the unmaintained RemarkableLamyEraser.

With the package, one can:

  • switch to the eraser by holding down the button of the stylus
  • double click to undo
  • triple click to redo

The upstream project uses a custom script for managing the installation which I used as a basis for the package scripts.
Currently, one cannot pass flags, but I plan to add this as well. Maybe using an env file which has a variable FLAGS which is then loaded via the service file.

Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the package recipe to better match the standards we have for our recipes as a whole. I've added comments with change suggestions.

Please also add a conflicts with the remarkable-stylus package, as these both handle the same thing, and installing both at the same time can cause unexpected results.

@MoritzBoehme
Copy link
Author

Please update the package recipe to better match the standards we have for our recipes as a whole. I've added comments with change suggestions.

Please also add a conflicts with the remarkable-stylus package, as these both handle the same thing, and installing both at the same time can cause unexpected results.

Thanks for the quick feedback! Will get right on it.

@MoritzBoehme MoritzBoehme force-pushed the add-rmstylusbutton branch 2 times, most recently from 59b0bbf to ba7ec37 Compare February 12, 2025 18:28
@MoritzBoehme
Copy link
Author

MoritzBoehme commented Feb 12, 2025

I have added the conflicts as well as a basic way to configure the package if desired via /opt/etc/rmstylusbutton.env. I do not know how this works in combination with package updates, though. Any changes will probably get overridden?
I'll search how other packages do it...

@MoritzBoehme
Copy link
Author

Well, it seems other packages do it similarly. Renamed the config file to end in .conf to make it clear that this is a config file.
Hope this complies with best practices and the style of this project.

@Eeems
Copy link
Member

Eeems commented Feb 12, 2025

Generally for this kind of configuration, users would create a systemd unit override. Configuration files are generally something that the underlying application reads. I'm not sure it's really something we would desire as a separate file in this case

@MoritzBoehme
Copy link
Author

Generally for this kind of configuration, users would create a systemd unit override. Configuration files are generally something that the underlying application reads. I'm not sure it's really something we would desire as a separate file in this case

Ah, okay. Thanks for clarifying. I'll read up on how this would work and change the package accordingly.

@Eeems
Copy link
Member

Eeems commented Feb 12, 2025

Generally for this kind of configuration, users would create a systemd unit override. Configuration files are generally something that the underlying application reads. I'm not sure it's really something we would desire as a separate file in this case

Ah, okay. Thanks for clarifying. I'll read up on how this would work and change the package accordingly.

A user would run systemctl edit rmstylusbutton, Make their modifications to pass the flags, save and exit. This would create an override file that overrides the settings they want to override. This would persist on package upgrades. They can remove the override file if they want to revert back to stock settings.

Apply suggestions from code review

Co-authored-by: Nathaniel van Diepen <[email protected]>
@Eeems Eeems added this to the 2025-W08 Merge Window milestone Feb 14, 2025
@Eeems Eeems merged commit 705b0de into toltec-dev:testing Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants