-
Notifications
You must be signed in to change notification settings - Fork 70
Add package for rmstylusbutton #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the package recipe to better match the standards we have for our recipes as a whole. I've added comments with change suggestions.
Please also add a conflicts with the remarkable-stylus
package, as these both handle the same thing, and installing both at the same time can cause unexpected results.
93ffdee
to
922aeeb
Compare
Thanks for the quick feedback! Will get right on it. |
59b0bbf
to
ba7ec37
Compare
I have added the conflicts as well as a basic way to configure the package if desired via /opt/etc/rmstylusbutton.env. I do not know how this works in combination with package updates, though. Any changes will probably get overridden? |
ba7ec37
to
9c5ea2a
Compare
Well, it seems other packages do it similarly. Renamed the config file to end in |
9c5ea2a
to
ed5c6e2
Compare
Generally for this kind of configuration, users would create a systemd unit override. Configuration files are generally something that the underlying application reads. I'm not sure it's really something we would desire as a separate file in this case |
Ah, okay. Thanks for clarifying. I'll read up on how this would work and change the package accordingly. |
A user would run |
Apply suggestions from code review Co-authored-by: Nathaniel van Diepen <[email protected]>
ed5c6e2
to
ac43564
Compare
I am adding the package RMStylusButton.
It's a fork of the unmaintained RemarkableLamyEraser.
With the package, one can:
The upstream project uses a custom script for managing the installation which I used as a basis for the package scripts.
Currently, one cannot pass flags, but I plan to add this as well. Maybe using an env file which has a variable FLAGS which is then loaded via the service file.