Skip to content

Prepare tracing-appender for release #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 5, 2020
Merged

Prepare tracing-appender for release #705

merged 7 commits into from
May 5, 2020

Conversation

thekeys93
Copy link
Contributor

@thekeys93 thekeys93 commented May 4, 2020

Following the release process for https://github.com/tokio-rs/tracing/blob/master/CONTRIBUTING.md and these changes are the only things left to commit before release.

I'd like to hopefully get this released today so we can start using this crate internally.

Note:
I need to get PR #703 and PR #678 merged before release.

@thekeys93 thekeys93 requested review from hawkw and a team as code owners May 4, 2020 16:21
@hawkw
Copy link
Member

hawkw commented May 4, 2020

I think there is a little more to do to get this ready to release. Let's also update the Cargo.toml to contain the standard set of metadata that other crates in the project have:

license = "MIT"
readme = "README.md"
repository = "https://github.com/tokio-rs/tracing"
homepage = "https://tokio.rs"
description = """
Application-level tracing for Rust.
"""
categories = [
"development-tools::debugging",
"development-tools::profiling",
"asynchronous",
"no-std",
]
keywords = ["logging", "tracing", "metrics", "async"]
edition = "2018"

(but don't add the no-std category because this crate does require the standard library)

Also, I'd like to give this crate a quick final API pass before publishing in case we need to change anything up.

I'd like to hopefully get this released today so we can start using this crate internally.

If you want to use the crate before it's ready to release, are you able to take a git dependency temporarily?

@hawkw
Copy link
Member

hawkw commented May 4, 2020

Note:
I need to get PR #703 and PR #678 merged before release.

I don't think it's necessary to block a crates.io release on the benchmarks. They aren't part of the crate's API and will primarily be useful internally for development purposes. I would like to merge the tests first, though.

@thekeys93
Copy link
Contributor Author

I'd like to hopefully get this released today so we can start using this crate internally.

If you want to use the crate before it's ready to release, are you able to take a git dependency temporarily?

Unfortunantely we aren't able to take a git dependency. The only way for us to use this is if there is a crate available for us.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks great! I'll get a release out soon.

Thanks again for all your hard work on this, @zekisherif!

If you have the chance, it would also be nice to have a follow-up PR adding this crate to the list of crates in the project here.

@thekeys93
Copy link
Contributor Author

Awesome! Thanks for all your help in the countless reviews.

I'll have a follow-up PR out later today.

@hawkw hawkw merged commit f8b52bd into tokio-rs:master May 5, 2020
@thekeys93 thekeys93 deleted the appender-release branch May 5, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants