-
Notifications
You must be signed in to change notification settings - Fork 804
Prepare tracing-appender for release #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think there is a little more to do to get this ready to release. Let's also update the Lines 13 to 27 in 5a971be
(but don't add the no-std category because this crate does require the standard library)
Also, I'd like to give this crate a quick final API pass before publishing in case we need to change anything up.
If you want to use the crate before it's ready to release, are you able to take a git dependency temporarily? |
Unfortunantely we aren't able to take a git dependency. The only way for us to use this is if there is a crate available for us. |
Co-authored-by: Eliza Weisman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this looks great! I'll get a release out soon.
Thanks again for all your hard work on this, @zekisherif!
If you have the chance, it would also be nice to have a follow-up PR adding this crate to the list of crates in the project here.
Awesome! Thanks for all your help in the countless reviews. I'll have a follow-up PR out later today. |
Following the release process for https://github.com/tokio-rs/tracing/blob/master/CONTRIBUTING.md and these changes are the only things left to commit before release.
I'd like to hopefully get this released today so we can start using this crate internally.
Note:
I need to get PR #703 and PR #678 merged before release.