tracing: add portable-atomic support to other tracing crates
#3246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `portable-atomic` support to: - `tracing` - `tracing-futures` - `tracing-serde` - `tracing-subscriber` Added `no_std` support to: - `tracing-macros` - `tracing-futures` Added CI task to catch regressions in `portable-atomic` _and_ `no_std` support.
bushrat011899
requested review from
hawkw,
carllerche,
davidbarsky and
a team
as code owners
hds
approved these changes
Apr 10, 2025
hds
changed the title
portable-atomic support to other tracing cratesportable-atomic support to other tracing crates
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands
portable-atomicutilisation within Tracing, improving platform support without breaking the existing public API.Motivation
Since #3199 was merged, it's now possible to bring more tracing crates to atomically challenged platforms through
portable-atomic. Additionally, CI is not currently setup to ensure this feature behaves as expected (allowing compilation on platforms with incomplete atomic support).Solution
portable-atomicsupport to:tracingtracing-futurestracing-serdetracing-subscriberno_stdsupport to:tracing-macrostracing-futuresportable-atomicandno_stdsupport.Notes
critical-sectionfeature is also added to make CI testing and usage oftracing/etc. on atomically challenged platforms simpler.portable-atomicas a dependency only occur when it would have already been included transitively viatracing-core'sportable-atomic-utildependency.core::sync::atomicwithportable-atomicto ensure the public API was unaffected. As such, this is not a breaking change, since it simply addsportable-atomicandcritical-sectionfeatures.