fix: subscriber context docs #2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kaffarell, thanks for the fix! I believe that this issue also exists in the documentation on the |
kaffarell
requested review from
yaahc,
carllerche and
davidbarsky
as code owners
kaffarell
force-pushed
the
subscriber_context_docs
branch
from
ca89c3c to
908cc43
Compare
In the documentation of the layer context span_scope method, the note contained a reference to a `scope()` method, which was removed some time ago. Also fixed a phrasing error above. Fixes: tokio-rs#2890
|
Oops, didn't mean to close it :) |
mladedav
approved these changes
May 15, 2024
davidbarsky
approved these changes
May 25, 2024
20 tasks
hds
pushed a commit
that referenced
this pull request
Nov 21, 2024
In the documentation of the layer context span_scope method, the note contained a reference to a `scope()` method, which was removed some time ago. Also fixed a phrasing error above. Fixes: #2890
hds
pushed a commit
that referenced
this pull request
Nov 22, 2024
In the documentation of the layer context span_scope method, the note contained a reference to a `scope()` method, which was removed some time ago. Also fixed a phrasing error above. Fixes: #2890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation of the layer context span_scope method, the note contained a reference to a
scope()method, which was removed some time ago. Also fixed a phrasing error above.Fixes: #2890