Skip to content

docs: document registry feature requirement for fmt feature #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023

Conversation

detly
Copy link
Contributor

@detly detly commented May 10, 2023

Motivation

This was inconsistent with other features, which mention their requirements, and a reader might assume they don't need to inspect the feature flags page or manifest.

Solution

Document the requirement.

## Motivation

This was inconsistent with other features, which mention their
requirements, and a reader might assume they don't need to inspect the
feature flags page or manifest.
@detly detly requested review from hawkw, davidbarsky and a team as code owners May 10, 2023 23:12
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this looks good to me!

@hawkw hawkw merged commit 2914626 into tokio-rs:master May 11, 2023
hawkw pushed a commit that referenced this pull request Jun 17, 2023
…#2590)

## Motivation

This was inconsistent with other features, which mention their
requirements, and a reader might assume they don't need to inspect the
feature flags page or manifest.
hawkw pushed a commit that referenced this pull request Jun 19, 2023
…#2590)

## Motivation

This was inconsistent with other features, which mention their
requirements, and a reader might assume they don't need to inspect the
feature flags page or manifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants