chore: update all crates to 2018 edition #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <[email protected]>
jonhoo
reviewed
Jun 29, 2019
| @@ -152,7 +152,7 @@ impl AsyncRead for MyTcpStream {} | |||
|
|
|||
| impl AsyncWrite for MyTcpStream { | |||
| fn shutdown(&mut self) -> Poll<(), io::Error> { | |||
| try!(self.0.lock().unwrap().shutdown(Shutdown::Write)); | |||
| r#try!(self.0.lock().unwrap().shutdown(Shutdown::Write)); | |||
There was a problem hiding this comment.
Huh, weird.. Should this be using ?
There was a problem hiding this comment.
probably --- this was a community contribution I think.
jonhoo
approved these changes
Jun 29, 2019
hawkw
added a commit
that referenced
this pull request
Jul 1, 2019
## Motivation #122 updated all crates to use Rust 2018 syntax, but I neglected to add `edition = "2018"` to the `Cargo.toml`s. ## Solution This fixes that. Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates everything to Rust 2018, since we
are no longer guaranteeing support for Rust versions prior
to that edition.
Closes #103
Signed-off-by: Eliza Weisman [email protected]