Skip to content

chore: update from opentelemetry-sdk 0.28.0 to 0.29.0 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Unreleased

### Breaking Changes

- Upgrade from opentelemetry 0.28.0 to 0.29.0. Refer to the upstream
[changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/CHANGELOG.md#0290)
for more information.

# 0.27.0 (October 9, 2024)

### Breaking Changes
Expand Down
14 changes: 7 additions & 7 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ metrics = ["opentelemetry/metrics","opentelemetry_sdk/metrics", "smallvec"]
metrics_gauge_unstable = []

[dependencies]
opentelemetry = { version = "0.28.0", default-features = false, features = ["trace"] }
opentelemetry_sdk = { version = "0.28.0", default-features = false, features = ["trace"] }
opentelemetry = { version = "0.29.0", default-features = false, features = ["trace"] }
opentelemetry_sdk = { version = "0.29.0", default-features = false, features = ["trace"] }
tracing = { version = "0.1.35", default-features = false, features = ["std"] }
tracing-core = "0.1.28"
tracing-subscriber = { version = "0.3.0", default-features = false, features = ["registry", "std"] }
Expand All @@ -43,11 +43,11 @@ smallvec = { version = "1.0", optional = true }
[dev-dependencies]
async-trait = "0.1.56"
criterion = { version = "0.5.1", default-features = false, features = ["html_reports"] }
opentelemetry = { version = "0.28.0", features = ["trace", "metrics"] }
opentelemetry_sdk = { version = "0.28.0", default-features = false, features = ["trace", "rt-tokio"] }
opentelemetry-stdout = { version = "0.28.0", features = ["trace", "metrics"] }
opentelemetry-otlp = { version = "0.28.0", features = ["metrics", "grpc-tonic"] }
opentelemetry-semantic-conventions = { version = "0.28.0", features = ["semconv_experimental"] }
opentelemetry = { version = "0.29.0", features = ["trace", "metrics"] }
opentelemetry_sdk = { version = "0.29.0", default-features = false, features = ["trace", "rt-tokio"] }
opentelemetry-stdout = { version = "0.29.0", features = ["trace", "metrics"] }
opentelemetry-otlp = { version = "0.29.0", features = ["metrics", "grpc-tonic"] }
opentelemetry-semantic-conventions = { version = "0.29.0", features = ["semconv_experimental"] }
futures-util = { version = "0.3.17", default-features = false }
tokio = { version = "1", features = ["full"] }
tokio-stream = "0.1"
Expand Down
8 changes: 4 additions & 4 deletions examples/opentelemetry-error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,17 +92,17 @@ fn main() -> Result<(), Box<dyn StdError + Send + Sync + 'static>> {
struct WriterExporter;

impl SpanExporter for WriterExporter {
fn export(
&mut self,
async fn export(
&self,
batch: Vec<sdk::trace::SpanData>,
) -> futures_util::future::BoxFuture<'static, OTelSdkResult> {
) -> OTelSdkResult {
let mut writer = std::io::stdout();
for span in batch {
writeln!(writer, "{}", SpanData(span)).unwrap();
}
writeln!(writer).unwrap();

Box::pin(async move { OTelSdkResult::Ok(()) })
OTelSdkResult::Ok(())
}
}

Expand Down
13 changes: 5 additions & 8 deletions tests/batch_global_subscriber.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures_util::future::BoxFuture;
use opentelemetry::{global as otel_global, trace::TracerProvider as _};
use opentelemetry_sdk::{
error::OTelSdkResult,
Expand All @@ -16,14 +15,12 @@ use std::sync::{Arc, Mutex};
struct TestExporter(Arc<Mutex<Vec<SpanData>>>);

impl SpanExporter for TestExporter {
fn export(&mut self, mut batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult> {
async fn export(&self, mut batch: Vec<SpanData>) -> OTelSdkResult {
let spans = self.0.clone();
Box::pin(async move {
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
})
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
}
}

Expand Down
13 changes: 5 additions & 8 deletions tests/errors.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures_util::future::BoxFuture;
use opentelemetry::trace::TracerProvider as _;
use opentelemetry_sdk::error::OTelSdkResult;
use opentelemetry_sdk::trace::{SdkTracerProvider, SpanData, SpanExporter, Tracer};
Expand Down Expand Up @@ -106,13 +105,11 @@ fn test_tracer(
struct TestExporter(Arc<Mutex<Vec<SpanData>>>);

impl SpanExporter for TestExporter {
fn export(&mut self, mut batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult> {
async fn export(&self, mut batch: Vec<SpanData>) -> OTelSdkResult {
let spans = self.0.clone();
Box::pin(async move {
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
})
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
}
}
13 changes: 5 additions & 8 deletions tests/filtered.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures_util::future::BoxFuture;
use opentelemetry::trace::TracerProvider as _;
use opentelemetry_sdk::error::OTelSdkResult;
use opentelemetry_sdk::trace::{SdkTracerProvider, SpanData, SpanExporter, Tracer};
Expand All @@ -12,14 +11,12 @@ use tracing_subscriber::prelude::*;
struct TestExporter(Arc<Mutex<Vec<SpanData>>>);

impl SpanExporter for TestExporter {
fn export(&mut self, mut batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult> {
async fn export(&self, mut batch: Vec<SpanData>) -> OTelSdkResult {
let spans = self.0.clone();
Box::pin(async move {
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
})
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
}
}

Expand Down
13 changes: 5 additions & 8 deletions tests/follows_from.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures_util::future::BoxFuture;
use opentelemetry::trace::TracerProvider as _;
use opentelemetry_sdk::{
error::OTelSdkResult,
Expand All @@ -13,14 +12,12 @@ use tracing_subscriber::prelude::*;
struct TestExporter(Arc<Mutex<Vec<SpanData>>>);

impl SpanExporter for TestExporter {
fn export(&mut self, mut batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult> {
async fn export(&self, mut batch: Vec<SpanData>) -> OTelSdkResult {
let spans = self.0.clone();
Box::pin(async move {
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
})
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
}
}

Expand Down
13 changes: 5 additions & 8 deletions tests/parallel.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures_util::future::BoxFuture;
use opentelemetry::trace::TracerProvider as _;
use opentelemetry_sdk::error::OTelSdkResult;
use opentelemetry_sdk::trace::{SdkTracerProvider, SpanData, SpanExporter, SpanLimits, Tracer};
Expand All @@ -12,14 +11,12 @@ use tracing_subscriber::prelude::*;
struct TestExporter(Arc<Mutex<Vec<SpanData>>>);

impl SpanExporter for TestExporter {
fn export(&mut self, mut batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult> {
async fn export(&self, mut batch: Vec<SpanData>) -> OTelSdkResult {
let spans = self.0.clone();
Box::pin(async move {
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
})
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
}
}

Expand Down
13 changes: 5 additions & 8 deletions tests/parents.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures_util::future::BoxFuture;
use opentelemetry::trace::TracerProvider as _;
use opentelemetry_sdk::error::OTelSdkResult;
use opentelemetry_sdk::trace::{SdkTracerProvider, SpanData, SpanExporter, Tracer};
Expand All @@ -12,14 +11,12 @@ use tracing_subscriber::prelude::*;
struct TestExporter(Arc<Mutex<Vec<SpanData>>>);

impl SpanExporter for TestExporter {
fn export(&mut self, mut batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult> {
async fn export(&self, mut batch: Vec<SpanData>) -> OTelSdkResult {
let spans = self.0.clone();
Box::pin(async move {
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
})
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
}
}

Expand Down
13 changes: 5 additions & 8 deletions tests/span_ext.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures_util::future::BoxFuture;
use opentelemetry::trace::{Status, TracerProvider as _};
use opentelemetry_sdk::{
error::OTelSdkResult,
Expand All @@ -14,14 +13,12 @@ use tracing_subscriber::prelude::*;
struct TestExporter(Arc<Mutex<Vec<SpanData>>>);

impl SpanExporter for TestExporter {
fn export(&mut self, mut batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult> {
async fn export(&self, mut batch: Vec<SpanData>) -> OTelSdkResult {
let spans = self.0.clone();
Box::pin(async move {
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
})
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
}
}

Expand Down
13 changes: 5 additions & 8 deletions tests/trace_state_propagation.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures_util::future::BoxFuture;
use opentelemetry::{
propagation::{TextMapCompositePropagator, TextMapPropagator},
trace::{SpanContext, TraceContextExt, Tracer as _, TracerProvider as _},
Expand Down Expand Up @@ -218,13 +217,11 @@ fn build_sampled_context() -> (Context, impl Subscriber, TestExporter, SdkTracer
struct TestExporter(Arc<Mutex<Vec<SpanData>>>);

impl SpanExporter for TestExporter {
fn export(&mut self, mut batch: Vec<SpanData>) -> BoxFuture<'static, OTelSdkResult> {
async fn export(&self, mut batch: Vec<SpanData>) -> OTelSdkResult {
let spans = self.0.clone();
Box::pin(async move {
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
})
if let Ok(mut inner) = spans.lock() {
inner.append(&mut batch);
}
Ok(())
}
}
Loading