Skip to content

feat(duckdb, spark, databricks): Support for ORDER BY ALL #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2024
Merged

feat(duckdb, spark, databricks): Support for ORDER BY ALL #3756

merged 1 commit into from
Jul 11, 2024

Conversation

VaggelisD
Copy link
Collaborator

Fixes #3755

For the dialects that support ORDER BY ALL such as DuckDB, Databricks, Spark3 (tested on 3.4+) parse ALL as an exp.Var and not as a column.

Docs

DuckDB ORDER BY | Databricks ORDER BY

@tobymao
Copy link
Owner

tobymao commented Jul 11, 2024 •
edited
Loading

i change my mind, maybe this is ok. can we do the same for group by all?

@VaggelisD
Copy link
Collaborator Author

@tobymao Sure, I'll do some research on GROUP BY ALL and follow up with a new PR

@georgesittas georgesittas merged commit e9c4bbb into main Jul 11, 2024
6 checks passed
@georgesittas georgesittas deleted the vaggelisd/orderby_all branch July 11, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order By All keyword is not correctly parsed
3 participants
@VaggelisD @tobymao @georgesittas