Skip to content

fix clang warnings - adjust array sizes #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Nathan-Fenner
Copy link
Contributor

Fixes some small warnings caught by clang about arrays being sized incorrectly:

  • keyList was slightly too short to have space for the last item, UNKNOWN_KEY
  • parentSpawnedItems were recently increased to length MACHINES_BUFFER_LENGTH (actually 200) in the .c file, but the declaration in the Rogue.h header was missed

Copy link
Owner

@tmewett tmewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tmewett tmewett changed the base branch from master to release November 14, 2024 20:46
@tmewett
Copy link
Owner

tmewett commented Nov 14, 2024

Could you rebase onto 'release'? I updated the PR target

@Nathan-Fenner Nathan-Fenner force-pushed the nf/fix-type-mismatch-warnings branch from 6a0228c to 85824ea Compare November 29, 2024 03:15
@Nathan-Fenner
Copy link
Contributor Author

Rebase onto release completed

@tmewett tmewett merged commit b9b6009 into tmewett:release Dec 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants