Fix broken syntax highlighting after the first submodule #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoPonzi
force-pushed
the
issue-284
branch
2 times, most recently
from
86742a7 to
823392b
Compare
lemmy
reviewed
Sep 29, 2024
a regex is being used to identify a module but there are actually two regexes, one for the start token and one for the end (see line 151 and 166). This section define the patterns that can be found inside the body, by adding `#module` I'm allowing recursively searching for modules. Signed-off-by: Federico Ponzi <[email protected]>
Signed-off-by: Federico Ponzi <[email protected]>
FedericoPonzi
force-pushed
the
issue-284
branch
from
823392b to
c187227
Compare
|
I've reworded the commit message, and pushed an additional commit to fix the warning I've forgot to push in the other pr. |
Signed-off-by: Federico Ponzi <[email protected]>
FedericoPonzi
force-pushed
the
issue-284
branch
from
c187227 to
fc0364f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284
I was also able to verify the update with a test.