Skip to content

Try loading a spec/cfg with the MC prefix before loading the #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

Try loading a spec/cfg with the MC prefix before loading the #233

merged 1 commit into from
Sep 21, 2021

Conversation

lemmy
Copy link
Member

@lemmy lemmy commented Aug 8, 2021

file matching the current editor

Essentially, this introduce the convention that TLC-related
modules and config files are prefixed with 'MC'.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lemmy
Copy link
Member Author

lemmy commented Aug 8, 2021

I have been using the feature for a while now and find it useful.

alygin
alygin suggested changes Sep 4, 2021
View reviewed changes
Copy link
Contributor

@alygin alygin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code doesn't compile

@lemmy
Copy link
Member Author

lemmy commented Sep 4, 2021 •
edited
Loading

Thanks for the review. I'm happy to revise the PR if we all agree that this MC convention (potentially extended to MC as prefix and suffix) is a good idea. Alternatively, the extension could open a file chooser instead of offering to create a config file if it can't find a .cfg file for the current editor.

@lemmy lemmy force-pushed the ModelNameConvention branch from f183aa8 to 5160ce3 Compare September 21, 2021 04:34
@lemmy
Try loading a spec/cfg with the MC prefix before loading the
901beb6 
file matching the current editor

Essentially, this introduce the convention that TLC-related
modules and config files are prefixed with 'MC'.
@lemmy lemmy force-pushed the ModelNameConvention branch from 5160ce3 to 901beb6 Compare September 21, 2021 22:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lemmy lemmy merged commit 2092aeb into tlaplus:master Sep 21, 2021
@lemmy
Copy link
Member Author

lemmy commented Sep 21, 2021 •
edited
Loading

@alygin Please review even though this has been merged. I"m confident, but a second pair of eyes never hurts. The reason why I've already merged is to test-drive the functionality at an internal workshop this week.

@klinvill klinvill mentioned this pull request Nov 14, 2021
Open
@lemmy lemmy mentioned this pull request May 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alygin alygin alygin requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemmy @alygin