-
Notifications
You must be signed in to change notification settings - Fork 9
feat: make Map implement MutableMapping interface #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 86.66% 86.72% +0.05%
==========================================
Files 24 25 +1
Lines 1200 1243 +43
==========================================
+ Hits 1040 1078 +38
- Misses 160 165 +5 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #249 will not alter performanceComparing Summary
|
cc @phisanti, how's this look to you? I could also add this to ND2.ome_metadata as a |
Adding all the OME metadata directly in the nd2 would be very useful, save me one function in the code. |
closes #248 ... This PR makes ome_types.model.Map behave like a proper mutable mapping. so, it's much easier to cast to/from a dict object:
after this PR, you can do:
prints:
and
also note that you would be able to use standard dict-like methods to modify the Map object (like
__getitem__
,__setitem__
,.get()
, etc...)