fix: DualOutput object has no attribute isatty
#57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encontered this error when I submit a slurm job in HPC, although `sys.stdout` doesn't have `isatty` here, it won't fail even if we don't set `NO_COLORS`, so I think it should be safe to skip the isatty check here under such condition. ```log File "colorful/init.py", line 133, in <module> sys.modules[name] = ColorfulModule(Colorful(), name) ^^^^^^^^^^ File "colorful/core.py", line 342, in init colormode = terminal.detect_color_support(env=os.environ) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "colorful/terminal.py", line 48, in detect_color_support if not sys.stdout.isatty(): ^^^^^^^^^^^^^^^^^ AttributeError: 'DualOutput' object has no attribute 'isatty' ``` Signed-off-by: Hollow Man <[email protected]>
|
sounds fair to me |
|
do you need this in a release? |
Thanks! I've already patched this locally, so I don't need a release for this. |
|
The CI stuff failed so i took the time to update that and created a release anyway so its also part of v0.5.7 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encontered this error when I submit a slurm job in HPC, although
sys.stdoutdoesn't haveisattyhere, it won't fail even if we don't setNO_COLORS, so I think it should be safe to skip the isatty check here under such condition.