Tag Page Generation Patch #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Onissom is attempting to deploy a commit to the timlrx's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the generation for tag pagination happens, if the site is built using GitHub Pages it gives the following error:
[Error: Page "/tags/[tag]/page/[page]" is missing "generateStaticParams()" so it cannot be used with "output: export" config.]This only occurs if there isn't enough tags to generate a second page of any tag that already exists in the blog, such as if you only have one public blog page prepared.
My first workaround to this was to modify the tags of the only blog to repeat the placeholder tag 6 times, however when checking the code more the modifications made below worked, allowing GitHub Pages to be built even when there isn't enough tags for a second page and still having proper pagination when the second page does exist.