Skip to content

Fix net test #8277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Fix net test #8277

merged 1 commit into from
Jul 15, 2025

Conversation

svenklemm
Copy link
Member

Switch out postman-echo.com test endpoint for httpbin.org

Switch out postman-echo.com test endpoint for httpbin.org
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (ea07da1) to head (8d87c3c).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8277      +/-   ##
==========================================
- Coverage   82.18%   81.93%   -0.26%     
==========================================
  Files         257      257              
  Lines       48263    48219      -44     
  Branches    12174    12167       -7     
==========================================
- Hits        39667    39507     -160     
- Misses       3721     3900     +179     
+ Partials     4875     4812      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to have our own echo server spun up as part of the job, but this solves the immediate problem so approving.

@fabriziomello
Copy link
Member

Would be better to have our own echo server spun up as part of the job, but this solves the immediate problem so approving.

Well this httpbin can be executed locally: https://github.com/postmanlabs/httpbin (but IMHO it can be material for a following PR)

@svenklemm svenklemm merged commit b772b05 into main Jul 15, 2025
51 of 60 checks passed
@svenklemm svenklemm deleted the sven/net_fix branch July 15, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants