Skip to content

Removed time_bucket_ng #8229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kpan2034
Copy link
Member

@kpan2034 kpan2034 commented Jun 5, 2025

No description provided.

@kpan2034 kpan2034 requested a review from fabriziomello June 5, 2025 23:05
@kpan2034 kpan2034 force-pushed the remove_time_bucket_ng branch 5 times, most recently from 40d674c to a6f1956 Compare June 10, 2025 14:25
@philkra philkra added this to the v2.21.0 milestone Jun 10, 2025
@kpan2034 kpan2034 force-pushed the remove_time_bucket_ng branch from a6f1956 to b2ba3ff Compare June 10, 2025 20:17
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.98%. Comparing base (a465f3f) to head (a3808dc).

Files with missing lines Patch % Lines
src/ts_catalog/continuous_agg.c 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8229      +/-   ##
==========================================
- Coverage   82.20%   81.98%   -0.22%     
==========================================
  Files         256      256              
  Lines       48170    47850     -320     
  Branches    12152    12061      -91     
==========================================
- Hits        39597    39229     -368     
- Misses       3710     3875     +165     
+ Partials     4863     4746     -117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kpan2034 kpan2034 force-pushed the remove_time_bucket_ng branch from b2ba3ff to d1a5746 Compare June 10, 2025 23:37
@kpan2034 kpan2034 marked this pull request as ready for review June 10, 2025 23:38
Copy link

@erimatnor, @akuzm: please review this pull request.

Powered by pull-review

@github-actions github-actions bot requested review from akuzm and erimatnor June 10, 2025 23:38
@kpan2034 kpan2034 force-pushed the remove_time_bucket_ng branch from d1a5746 to f2dc83a Compare June 11, 2025 12:54
@kpan2034 kpan2034 force-pushed the remove_time_bucket_ng branch from f2dc83a to a3808dc Compare June 11, 2025 13:38
@fabriziomello fabriziomello removed this from the v2.21.0 milestone Jun 23, 2025
Comment on lines +66 to +94

CREATE OR REPLACE FUNCTION timescaledb_experimental.time_bucket_ng(bucket_width INTERVAL, ts DATE) RETURNS DATE
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C IMMUTABLE PARALLEL SAFE STRICT;

CREATE OR REPLACE FUNCTION timescaledb_experimental.time_bucket_ng(bucket_width INTERVAL, ts DATE, origin DATE) RETURNS DATE
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C IMMUTABLE PARALLEL SAFE STRICT;

CREATE OR REPLACE FUNCTION timescaledb_experimental.time_bucket_ng(bucket_width INTERVAL, ts TIMESTAMP) RETURNS TIMESTAMP
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C IMMUTABLE PARALLEL SAFE STRICT;

CREATE OR REPLACE FUNCTION timescaledb_experimental.time_bucket_ng(bucket_width INTERVAL, ts TIMESTAMP, origin TIMESTAMP) RETURNS TIMESTAMP
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C IMMUTABLE PARALLEL SAFE STRICT;

CREATE OR REPLACE FUNCTION timescaledb_experimental.time_bucket_ng(bucket_width INTERVAL, ts TIMESTAMPTZ, timezone TEXT) RETURNS TIMESTAMPTZ
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C IMMUTABLE PARALLEL SAFE STRICT;

CREATE OR REPLACE FUNCTION timescaledb_experimental.time_bucket_ng(bucket_width INTERVAL, ts TIMESTAMPTZ, origin TIMESTAMPTZ, timezone TEXT) RETURNS TIMESTAMPTZ
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C IMMUTABLE PARALLEL SAFE STRICT;

CREATE OR REPLACE FUNCTION timescaledb_experimental.time_bucket_ng(bucket_width INTERVAL, ts TIMESTAMPTZ) RETURNS TIMESTAMPTZ
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C STABLE PARALLEL SAFE STRICT;

CREATE OR REPLACE FUNCTION timescaledb_experimental.time_bucket_ng(bucket_width INTERVAL, ts TIMESTAMPTZ, origin TIMESTAMPTZ) RETURNS TIMESTAMPTZ
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C STABLE PARALLEL SAFE STRICT;

-- Migrate a CAgg which is using the experimental time_bucket_ng function
-- into a CAgg using the regular time_bucket function
CREATE OR REPLACE PROCEDURE _timescaledb_functions.cagg_migrate_to_time_bucket(cagg REGCLASS)
AS '@MODULE_PATHNAME@', 'ts_update_placeholder' LANGUAGE C;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants