Fix dropped quals bug in skipscan #8216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkindahl, @svenklemm: please review this pull request.
|
natalya-aksman
force-pushed
the
fix_dropped_index_quals_in_skipscan
branch
from
412066c to
6934f20
Compare
natalya-aksman
requested review from
svenklemm and
akuzm
and removed request for
svenklemm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8216 +/- ##
==========================================
+ Coverage 82.29% 82.36% +0.07%
==========================================
Files 256 256
Lines 48027 47999 -28
Branches 12117 12114 -3
==========================================
+ Hits 39522 39536 +14
- Misses 3644 3658 +14
+ Partials 4861 4805 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akuzm
reviewed
Jun 3, 2025
Fix dropped quals bug in skipscan, add changelog Fix dropped quals bug in skipscan, address comments
natalya-aksman
force-pushed
the
fix_dropped_index_quals_in_skipscan
branch
from
6934f20 to
61aa6f9
Compare
svenklemm
approved these changes
Jun 3, 2025
akuzm
approved these changes
Jun 3, 2025
timescale-automation
pushed a commit
that referenced
this pull request
Jun 3, 2025
timescale-automation
pushed a commit
that referenced
this pull request
Jun 3, 2025
natalya-aksman
added a commit
to natalya-aksman/timescaledb
that referenced
this pull request
Jun 5, 2025
Merged
philkra
added a commit
that referenced
this pull request
Jun 11, 2025
## 2.20.3 (2025-06-11) This release contains bug fixes since the 2.20.2 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * [#8107](#8107) Adjust SkipScan cost for quals needing full scan of indexed data. * [#8211](#8211) Fixed dump and restore when chunk skipping is enabled. * [#8216](#8216) Fix for dropped quals bug in SkipScan. * [#8230](#8230) Fix for inserting into compressed data when a vectorized check is not available. * [#8236](#8236) Fixed the snapshot handling in background workers. **Thanks** * @ikaakkola for reporting that SkipScan is slow when non-index quals do not match any tuples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8217
Also fixes failed Sanitizer runs div by NULL issue which appeared after commit for #8210: https://github.com/timescale/timescaledb/actions/runs/15419915713/job/43391984943