Add columnstore option to CREATE TABLE WITH

[svenklemm]

Allow opting out of columnstore when creating hypertable with
CREATE TABLE WITH. To prevent having the defaults for CREATE TABLE
WITH be different between licenses this is a required option when
using apache license otherwise a license error will be thrown.

[github-actions]

@erimatnor, @fabriziomello: please review this pull request.

Powered by pull-review

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (09cd3d6) to head (8181d1a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/cross_module_fn.c	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8178      +/-   ##
==========================================
+ Coverage   82.32%   82.39%   +0.07%     
==========================================
  Files         256      256              
  Lines       47931    47906      -25     
  Branches    12077    12073       -4     
==========================================
+ Hits        39457    39473      +16     
- Misses       3636     3651      +15     
+ Partials     4838     4782      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[akuzm]

Can we make it automatically default to "off" when the user is using Apache? It's kind of weird to make them manually specify they don't need compression again and again, after they have already chosen the version that doesn't support it.

[svenklemm]

Can we make it automatically default to "off" when the user is using Apache? It's kind of weird to make them manually specify they don't need compression again and again, after they have already chosen the version that doesn't support it.

This is intential, the outcome of a command should not be affected by the current license, that would just lead to confusion.

[akuzm]

Can we make it automatically default to "off" when the user is using Apache? It's kind of weird to make them manually specify they don't need compression again and again, after they have already chosen the version that doesn't support it.

This is intential, the outcome of a command should not be affected by the current license, that would just lead to confusion.

Do we expect license changes to happen often? I was under the impression that people just chose it once per installation and generally stick with it. In this case, having the default value for the command harmonized with the license choice might be not so bad.

[svenklemm]

Can we make it automatically default to "off" when the user is using Apache? It's kind of weird to make them manually specify they don't need compression again and again, after they have already chosen the version that doesn't support it.

This is intential, the outcome of a command should not be affected by the current license, that would just lead to confusion.

Do we expect license changes to happen often? I was under the impression that people just chose it once per installation and generally stick with it. In this case, having the default value for the command harmonized with the license choice might be not so bad.

People are sometimes on wrong license either because of using wrong package or bugs.