Use proper ERRCODE #8043
Draft
Use proper ERRCODE #8043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8043 +/- ##
==========================================
+ Coverage 80.06% 82.26% +2.20%
==========================================
Files 190 253 +63
Lines 37181 46898 +9717
Branches 9450 11808 +2358
==========================================
+ Hits 29770 38582 +8812
- Misses 2997 3645 +648
- Partials 4414 4671 +257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akuzm
reviewed
May 5, 2025
| @@ -20,7 +20,7 @@ FUNCTION_NAME2(check_arrow, CTYPE)(ArrowArray *arrow, int error_type, Decompress | |||
| if (n != arrow->length) | |||
| { | |||
| ereport(error_type, | |||
| (errcode(ERRCODE_INTERNAL_ERROR), | |||
| (errcode(ERRCODE_TS_UNEXPECTED), | |||
There was a problem hiding this comment.
This should throw internal error because it's a bug
akuzm
reviewed
May 5, 2025
| @@ -1124,7 +1127,7 @@ compression_setting_orderby_get_default(Hypertable *ht, ArrayType *segmentby) | |||
| 0 /*count*/); | |||
| if (res < 0) | |||
| ereport(ERROR, | |||
| (errcode(ERRCODE_INTERNAL_ERROR), | |||
| (errcode(ERRCODE_TS_UNEXPECTED), | |||
There was a problem hiding this comment.
This looks more of an internal error than user error. What can the user do to avoid/fix this? If nothing, and they are supposed to report this as a bug, it should be an internal error.
akuzm
reviewed
May 5, 2025
| @@ -417,7 +418,7 @@ create_compress_chunk(Hypertable *compress_ht, Chunk *src_chunk, Oid table_id) | |||
|
|
|||
| if (namelen >= NAMEDATALEN) | |||
| ereport(ERROR, | |||
| (errcode(ERRCODE_INTERNAL_ERROR), | |||
| (errcode(ERRCODE_TS_UNEXPECTED), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.