Skip default segmentby if orderby is explicitly set #8033

Poroma-Banerjee · 2025-04-30T19:27:20Z

Avoid assigning a default segmentby when the user specifies an orderby column. This prevents cases where both segmentby and orderby end up using the same column unintentionally.

Fixes #8030

svenklemm · 2025-04-30T19:46:26Z

run.sh

+#!/bin/bash
+
+#set -x
+
+PGPATH=${PGPATH:-/usr/local/pgsql}
+PGBIN=${PGPATH}/bin
+PATH=${PGBIN}:$PATH
+DBCLUSTER=${DBCLUSTER:-~/dbcluster/}
+PGUSER=${PGUSER:-postgres}
+
+export PATH
+
+${PGBIN}/pg_ctl -D ${DBCLUSTER} stop
+
+if [ "$1" = "stop" ]; then
+    exit;
+elif [ "$1" = "init" ]; then
+    echo "Initializing cluster in ${DBCLUSTER}"
+    rm -rf ${DBCLUSTER}
+    mkdir ${DBCLUSTER}
+    ${PGBIN}/initdb -U ${PGUSER} -D ${DBCLUSTER}
+fi
+
+pushd build
+make
+sudo make install
+popd
+
+${PGBIN}/pg_ctl -U ${PGUSER} -D ${DBCLUSTER} -l ${DBCLUSTER}/pg.log -o "-h 127.0.0.1 -p 5432 -cshared_preload_libraries='timescaledb'"  start
+/usr/local/pgsql/bin/psql -U postgres -d postgres -c "create extension timescaledb;"


Did you add this file by accident?

Did you add this file by accident?

Yes. removed the file

svenklemm · 2025-04-30T19:47:06Z

.unreleased/pr_8033

@@ -0,0 +1,2 @@
+Fixes: #8033 Skip default segmentby if orderby is explicitly set
+Thanks: @antekresic for reporting that default segmentby can select an user set orderby column


We usually use Thanks only for non-timescale contributors

Avoid assigning a default segmentby when the user specifies an orderby column. This prevents cases where both segmentby and orderby end up using the same column unintentionally.

codecov · 2025-04-30T20:30:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (59f50f2) to head (2ad246e).
Report is 1009 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8033      +/-   ##
==========================================
+ Coverage   80.06%   82.11%   +2.04%     
==========================================
  Files         190      253      +63     
  Lines       37181    46805    +9624     
  Branches     9450    11778    +2328     
==========================================
+ Hits        29770    38434    +8664     
- Misses       2997     3687     +690     
- Partials     4414     4684     +270

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

timescale-automation · 2025-04-30T20:49:33Z

Automated backport to 2.19.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.19.x
You are currently cherry-picking commit 65fb33535.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .unreleased/pr_8033
	modified:   tsl/src/compression/create.c
	modified:   tsl/test/expected/chunk_column_stats-15.out
	modified:   tsl/test/sql/chunk_column_stats.sql.in
	modified:   tsl/test/sql/compression_defaults.sql

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   tsl/test/expected/bgw_custom.out
	both modified:   tsl/test/expected/bgw_db_scheduler_fixed.out
	both modified:   tsl/test/expected/cagg_ddl-15.out
	both modified:   tsl/test/expected/cagg_ddl-16.out
	both modified:   tsl/test/expected/cagg_ddl-17.out
	both modified:   tsl/test/expected/cagg_errors.out
	both modified:   tsl/test/expected/cagg_migrate.out
	both modified:   tsl/test/expected/cagg_policy.out
	both modified:   tsl/test/expected/compress_bgw_reorder_drop_chunks.out
	both modified:   tsl/test/expected/compression.out
	deleted by us:   tsl/test/expected/compression_bool_vectorized.out
	both modified:   tsl/test/expected/compression_bools.out
	both modified:   tsl/test/expected/compression_ddl.out
	both modified:   tsl/test/expected/compression_defaults.out
	both modified:   tsl/test/expected/compression_errors-16.out
	both modified:   tsl/test/expected/compression_hypertable.out
	both modified:   tsl/test/expected/compression_insert.out
	both modified:   tsl/test/expected/compression_merge.out
	both modified:   tsl/test/expected/compression_nulls_and_defaults.out
	both modified:   tsl/test/expected/compression_qualpushdown.out
	both modified:   tsl/test/expected/compression_sequence_num_removal.out
	both modified:   tsl/test/expected/compression_settings.out
	both modified:   tsl/test/expected/compression_update_delete-15.out
	both modified:   tsl/test/expected/compression_update_delete-16.out
	both modified:   tsl/test/expected/compression_update_delete-17.out
	both modified:   tsl/test/expected/continuous_aggs-15.out
	both modified:   tsl/test/expected/continuous_aggs-16.out
	both modified:   tsl/test/expected/continuous_aggs-17.out
	both modified:   tsl/test/expected/hypercore.out
	both modified:   tsl/test/expected/hypercore_index_btree.out
	both modified:   tsl/test/expected/hypercore_insert.out
	both modified:   tsl/test/expected/hypercore_vacuum.out
	both modified:   tsl/test/expected/insert_memory_usage.out
	both modified:   tsl/test/shared/expected/cagg_compression.out
	both modified:   tsl/test/shared/expected/decompress_placeholdervar.out

Job log

@arajkumar

## 2.20.0 (2025-05-15) This release contains performance improvements and bug fixes since the 2.19.3 release. We recommend that you upgrade at the next available opportunity. **Highlighted features in TimescaleDB v2.20.0** * The columnstore now leverages *bloom filters* to deliver up to 6x faster point queries on columns with high cardinality values, such as UUIDs. * Major *improvements to the columnstores' backfill process* enable `UPSERTS` with strict constraints to execute up to 10x faster. * *SkipScan is now supported in the columnstore*, including for DISTINCT queries. This enhancement leads to dramatic query performance improvements of 2000x to 2500x, especially for selective queries. * SIMD vectorization for the bool data type is now enabled by default. This change results in a 30–45% increase in performance for analytical queries with bool clauses on the columnstore. * *Continuous aggregates* now include experimental support for *window functions and non-immutable functions*, extending the analytics use cases they can solve. * Several quality-of-life improvements have been introduced: job names for continuous aggregates are now more descriptive, you can assign custom names to them, and it is now possible to add unique constraints along with `ADD COLUMN` operations in the columnstore. * Improved management and optimization of chunks with the ability to split large uncompressed chunks at a specified point in time using the `split_chunk` function. This new function complements the existing `merge_chunk` function that can be used to merge two small chunks into one larger chunk. * Enhancements to the default behavior of the columnstore now provide better *automatic assessments* of `segment by` and `order by` columns, reducing the need for manual configuration and simplifying initial setup. **PostgreSQL 14 support removal announcement** Following the deprecation announcement for PostgreSQL 14 in TimescaleDB v2.19.0, PostgreSQL 14 is no longer supported in TimescaleDB v2.20.0. The currently supported PostgreSQL major versions are 15, 16, and 17. **Features** * [#7638](#7638) Bloom filter sparse indexes for compressed columns. Can be disabled with the GUC `timescaledb.enable_sparse_index_bloom` * [#7756](#7756) Add warning for poor compression ratio * [#7762](#7762) Speed up the queries that use minmax sparse indexes on compressed tables by changing the index TOAST storage type to `MAIN`. This applies to newly compressed chunks * [#7785](#7785) Do `DELETE` instead of `TRUNCATE` when locks aren't acquired * [#7852](#7852) Allow creating foreign key constraints on compressed tables * [#7854](#7854) Remove support for PG14 * [#7864](#7854) Allow adding CHECK constraints to compressed chunks * [#7868](#7868) Allow adding columns with `CHECK` constraints to compressed chunks * [#7874](#7874) Support for SkipScan for distinct aggregates over the same column * [#7877](#7877) Remove blocker for unique constraints with `ADD COLUMN` * [#7878](#7878) Don't block non-immutable functions in continuous aggregates * [#7880](#7880) Add experimental support for window functions in continuous aggregates * [#7899](#7899) Vectorized decompression and filtering for boolean columns * [#7915](#7915) New option `refresh_newest_first` to continuous aggregate refresh policy API * [#7917](#7917) Remove `_timescaledb_functions.create_chunk_table` function * [#7929](#7929) Add `CREATE TABLE ... WITH` API for creating hypertables * [#7946](#7946) Add support for splitting a chunk * [#7958](#7958) Allow custom names for jobs * [#7972](#7972) Add vectorized filtering for constraint checking while backfilling into compressed chunks * [#7976](#7976) Include continuous aggregate name in jobs informational view * [#7977](#7977) Replace references to compression with columnstore * [#7981](#7981) Add columnstore as alias for `enable_columnstore `in `ALTER TABLE` * [#7983](#7983) Support for SkipScan over compressed data * [#7991](#7991) Improves default `segmentby` options * [#7992](#7992) Add API into hypertable invalidation log * [#8000](#8000) Add primary dimension info to information schema * [#8005](#8005) Support `ALTER TABLE SET (timescaledb.chunk_time_interval='1 day')` * [#8012](#8012) Add event triggers support on chunk creation * [#8014](#8014) Enable bool compression by default by setting `timescaledb.enable_bool_compression=true`. Note: for downgrading to `2.18` or earlier version, use [this downgrade script](https://github.com/timescale/timescaledb-extras/blob/master/utils/2.19.0-downgrade_new_compression_algorithms.sql) * [#8018](#8018) Add spin-lock during recompression on unique constraints * [#8026](#8026) Allow `WHERE` conditions that use nonvolatile functions to be pushed down to the compressed scan level. For example, conditions like `time > now()`, where `time` is a columnstore `orderby` column, will evaluate `now()` and use the sparse index on `time` to filter out the entire compressed batches that cannot contain matching rows. * [#8027](#8027) Add materialization invalidations API * [#8047](#8027) Support SkipScan for `SELECT DISTINCT` with multiple distincts when all but one distinct is pinned * [#8115](#8115) Add batch size limiting during compression **Bugfixes** * [#7862](#7862) Release cache pin when checking for `NOT NULL` * [#7909](#7909) Update compression stats when merging chunks * [#7928](#7928) Don't create a hypertable for implicitly published tables * [#7982](#7982) Fix crash in batch sort merge over eligible expressions * [#8008](#8008) Fix compression policy error message that shows number of successes * [#8031](#8031) Fix reporting of deleted tuples for direct batch delete * [#8033](#8033) Skip default `segmentby` if `orderby` is explicitly set * [#8061](#8061) Ensure settings for a compressed relation are found * [#7515](#7515) Add missing lock to Constraint-aware append * [#8067](#8067) Make sure hypercore TAM parent is vacuumed * [#8074](#8074) Fix memory leak in row compressor flush * [#8099](#8099) Block chunk merging on multi-dimensional hypertables * [#8106](#8106) Fix segfault when adding unique compression indexes to compressed chunks * [#8127](#8127) Read bit-packed version of booleans **GUCs** * `timescaledb.enable_sparse_index_bloom`: Enable creation of the bloom1 sparse index on compressed chunks; Default: `ON` * `timescaledb.compress_truncate_behaviour`: Defines how truncate behaves at the end of compression; Default: `truncate_only` * `timescaledb.enable_compression_ratio_warnings`: Enable warnings for poor compression ratio; Default: `ON` * `timescaledb.enable_event_triggers`: Enable event triggers for chunks creation; Default: `OFF` * `timescaledb.enable_cagg_window_functions`: Enable window functions in continuous aggregates; Default: `OFF` **Thanks** * @arajkumar for reporting that implicitly published tables were still able to create hypertables * @thotokraa for reporting an issue with unique expression indexes on compressed chunks --------- Signed-off-by: Philip Krauss <[email protected]> Signed-off-by: Ramon Guiu <[email protected]> Co-authored-by: Anastasiia Tovpeko <[email protected]> Co-authored-by: Ramon Guiu <[email protected]>

github-actions bot assigned Poroma-Banerjee Apr 30, 2025

Poroma-Banerjee force-pushed the iss8030 branch from 3cf9495 to beac356 Compare April 30, 2025 19:34

Poroma-Banerjee requested review from kpan2034, fabriziomello, natalya-aksman and svenklemm April 30, 2025 19:34

svenklemm reviewed Apr 30, 2025

View reviewed changes

Poroma-Banerjee force-pushed the iss8030 branch 3 times, most recently from 3941d6b to d70ca0e Compare April 30, 2025 19:56

akuzm approved these changes Apr 30, 2025

View reviewed changes

svenklemm approved these changes Apr 30, 2025

View reviewed changes

Skip default segmentby if orderby is explicitly set

2ad246e

Avoid assigning a default segmentby when the user specifies an orderby column. This prevents cases where both segmentby and orderby end up using the same column unintentionally.

Poroma-Banerjee force-pushed the iss8030 branch from d70ca0e to 2ad246e Compare April 30, 2025 20:18

Poroma-Banerjee merged commit 65fb335 into timescale:main Apr 30, 2025
40 checks passed

timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Apr 30, 2025

philkra added this to the v2.20.0 milestone May 1, 2025

This was referenced May 7, 2025

Changelog 2.20.0 #8068

Closed

changelog 2.20.0 #8124

Merged

bayandin mentioned this pull request May 15, 2025

timescaledb 2.20.0 bayandin/homebrew-tap#280

Closed

akuzm added the released-2.20.0 Released in 2.20.0 label May 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip default segmentby if orderby is explicitly set #8033

Skip default segmentby if orderby is explicitly set #8033

Uh oh!

Poroma-Banerjee commented Apr 30, 2025 •

edited

Loading

Uh oh!

svenklemm Apr 30, 2025

Uh oh!

Poroma-Banerjee Apr 30, 2025

Uh oh!

svenklemm Apr 30, 2025 •

edited

Loading

Uh oh!

codecov bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

timescale-automation commented Apr 30, 2025

Uh oh!

Uh oh!

		@@ -0,0 +1,2 @@
		Fixes: #8033 Skip default segmentby if orderby is explicitly set
		Thanks: @antekresic for reporting that default segmentby can select an user set orderby column

Skip default segmentby if orderby is explicitly set #8033

Skip default segmentby if orderby is explicitly set #8033

Uh oh!

Conversation

Poroma-Banerjee commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svenklemm Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Poroma-Banerjee Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

svenklemm Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

timescale-automation commented Apr 30, 2025

Git status

Uh oh!

Uh oh!

Poroma-Banerjee commented Apr 30, 2025 •

edited

Loading

svenklemm Apr 30, 2025 •

edited

Loading

codecov bot commented Apr 30, 2025 •

edited

Loading